feat: detect visual studio preview as external tools #1553
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The vswhere binary is installed with the Visual Studio Installer. Alternatively, we could ship with the vswhere binary with the following: <!-- Testing for windows as target platform. fallback to true when no identifier is set so a nuget restore still works -->
<ItemGroup Condition="'$(RuntimeIdentifier)' == '' OR $([MSBuild]::StartsWith('$(RuntimeIdentifier)', 'win'))">
<PackageReference Include="vswhere" Version="3.1.7" GeneratePathProperty="True" PrivateAssets="all" />
<Content Include="$(PkgVswhere)\tools\vswhere.exe" Visible="False" Link="vswhere.exe" CopyToOutputDirectory="PreserveNewest" />
</ItemGroup>But this seems to work fine. |
love-linger
added a commit
that referenced
this pull request
Jul 11, 2025
Co-authored-by: Luis Frey <[email protected]> Signed-off-by: leo <[email protected]>
|
I've pushed my implementation of this PR that based on your idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds detection for Visual Studio Preview, as described in #1519.